Distributed Tracing integration with SDK builds. #2741

LarryOsterman · 2025-06-30T16:09:52Z

Added distributed tracing policy and example service client integration.

PR Changes:

Implemented RequestInstrumentationPolicy to add spans for HTTP operations.
Implemented PublicApiInstrumentationPolicy to add spans for public APIs.
Added public struct PublicApiInstrumentationInformation which expresses information used to create Public API spans.
Integrated RequestInstrumentationPolicy and PublicApiInstrumentationPolicy to azure_core pipeline creation.
1. Changed the azure_core::ClientOptions::deconstruct() method to deconstruct to a typespec_client_core::ClientOptions and a azure_core::CoreClientOptions (which is crate-private).
2. Added http::Method::as_str() to return a string slice with the name of the HTTP method.
Added span support for header propagation.
PR feedback from previous PR (removed Span::add_event, removed AttributeValue::U64 and replaced it with AttributeValue::F64),

Bug fix: Propagate retry policy options from client options to retry policy.

sdk/core/azure_core/src/http/policies/request_instrumentation.rs

lmolkova

Left some cosmetic comments, look great in general!

sdk/core/azure_core/src/http/policies/request_instrumentation.rs

… OpenTelemetry provider

LarryOsterman · 2025-07-16T22:12:15Z

@heaths @lmolkova @analogrelay @RickWinter At this point, I think I'm done with this PR, let me know what you think about it.

analogrelay

Still working my way through most of azure_core_opentelemetry but wrapping up my day and wanted to get some of the comments out there. Almost entirely style/idiom stuff, with a few other thoughts on the proc macro and attribute key storage. Looking good! I like the proc macros!

sdk/core/azure_core_macros/src/tracing.rs

sdk/core/azure_core/src/http/policies/instrumentation/mod.rs

sdk/core/azure_core/src/http/policies/instrumentation/public_api_instrumentation.rs

sdk/core/azure_core_macros/src/tracing_new.rs

sdk/core/azure_core_macros/src/tracing_subclient.rs

sdk/typespec/typespec_client_core/src/tracing/attributes.rs

doc/distributed-tracing-for-rust-service-clients.md

sdk/core/azure_core/src/http/policies/instrumentation/mod.rs

sdk/core/azure_core/src/http/policies/instrumentation/public_api_instrumentation.rs

sdk/core/azure_core/src/http/policies/instrumentation/request_instrumentation.rs

Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>

…://github.com/LarryOsterman/azure-sdk-for-rust into larryo/opentelemetry_prototype_implementation

…ve test reliability

Copilot

Pull Request Overview

This PR implements distributed tracing integration with the Azure SDK for Rust builds, adding comprehensive telemetry support for HTTP operations and public APIs. The implementation includes two main instrumentation policies and integrates them into the core pipeline creation process.

Key Changes:

Implemented RequestInstrumentationPolicy to add spans for HTTP operations with W3C trace context propagation
Implemented PublicApiInstrumentationPolicy to add spans for public API calls
Added comprehensive tracing attribute support with OpenTelemetry compatibility
Integrated instrumentation policies into the azure_core pipeline with client options configuration

Reviewed Changes

Copilot reviewed 41 out of 42 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
sdk/typespec/typespec_client_core/src/tracing/	Core tracing trait definitions with updated APIs for span creation and attribute handling
sdk/core/azure_core_opentelemetry/	OpenTelemetry integration implementation with tracer provider and span management
sdk/core/azure_core_macros/	Procedural macros for automatic instrumentation of client structs and methods
sdk/core/azure_core/src/http/policies/instrumentation/	HTTP request instrumentation policy with telemetry attributes
sdk/typespec/typespec_client_core/src/http/	Pipeline and retry policy updates for instrumentation support

sdk/typespec/typespec_client_core/src/tracing/mod.rs

sdk/core/azure_core_opentelemetry/src/tracer.rs

sdk/core/azure_core_opentelemetry/src/span.rs

sdk/core/azure_core_test/src/tracing.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions bot added the Azure.Core The azure_core crate label Jun 30, 2025

LarryOsterman added 13 commits June 30, 2025 15:33

PR feedback from previous PR

c541514

Start of a dummy service client upon which to hang tracing stuff

d64c714

Create RequestInstrumentationPolicy to add spans for HTTP operations

a5d6b2d

Telemetry static strings again

c72cc32

http::Method as_str()

db6c352

Added service tracing spans; populate az.namespace

16b26b8

Added test recording for opentelemetry tests

e785237

cargo publish fix

534b950

cargo publish fix 2

1da7fd7

Oops, commited too little stuff

726466e

OTel feedback from Liudmila

6d9c143

Propagate OpenTelemetry trace headers into request headers

85de5a9

More documentation

baccb1b

LarryOsterman force-pushed the larryo/opentelemetry_prototype_implementation branch from 32c2ac1 to baccb1b Compare June 30, 2025 22:38

LarryOsterman added 2 commits June 30, 2025 15:56

Small cleanup on propagate_headers

7629a8c

Started filling out OpenTelemetry readme.md

ec08e04

lmolkova reviewed Jul 1, 2025

View reviewed changes

sdk/core/azure_core/src/http/policies/request_instrumentation.rs Outdated Show resolved Hide resolved

lmolkova reviewed Jul 1, 2025

View reviewed changes

sdk/core/azure_core/src/http/policies/request_instrumentation.rs Outdated Show resolved Hide resolved

lmolkova reviewed Jul 1, 2025

View reviewed changes

sdk/core/azure_core/src/http/policies/request_instrumentation.rs Outdated Show resolved Hide resolved

lmolkova approved these changes Jul 1, 2025

View reviewed changes

LarryOsterman added 6 commits July 1, 2025 12:03

PR feedback from Liudmila

0daa061

Cargo fmt fixes

5c14d45

Removed unused public function

caef252

Added the ability to configure an OpenTelemetryProvider on the global…

5e48398

… OpenTelemetry provider

Documentation updates

be61079

Corrected name of opentelemetry package

9cb989c

LarryOsterman linked an issue Jul 8, 2025 that may be closed by this pull request

Implement Distributed Tracing conventions for Azure SDK clients. #2765

Closed

LarryOsterman added 2 commits July 8, 2025 13:17

First cut at EH perf tests

06afa82

PR feedback from previous PR

2017281

Added tracing::subclient to express subclient instantiation

6d1bb0d

LarryOsterman linked an issue Jul 16, 2025 that may be closed by this pull request

Implement proc macros to simplify the authoring experience for Distributed Tracing #2766

Closed

LarryOsterman added 2 commits July 16, 2025 10:29

Added subclient to cspell.json

c2ebbf2

Added subclient text to distributed tracing documentation

41571b7

analogrelay reviewed Jul 17, 2025

View reviewed changes

PR feedback part 1 - does not pass tests currently

5d95e02

lmolkova reviewed Jul 21, 2025

View reviewed changes

LarryOsterman and others added 7 commits July 21, 2025 11:48

Added support for Arc::new

cd99701

Update doc/distributed-tracing-for-rust-service-clients.md

2e2105a

Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>

PR feedback

7cf7fe7

Merge branch 'larryo/opentelemetry_prototype_implementation' of https…

c77fcaa

…://github.com/LarryOsterman/azure-sdk-for-rust into larryo/opentelemetry_prototype_implementation

PR feedback

c8893c5

Removed unnecessary modification

aa0f99a

Use azuresdkforcpp web server instead of actual live servers to impro…

bd42d8e

…ve test reliability

RickWinter requested a review from Copilot July 22, 2025 17:56

RickWinter approved these changes Jul 22, 2025

View reviewed changes

Copilot AI reviewed Jul 22, 2025

View reviewed changes

LarryOsterman and others added 5 commits July 22, 2025 11:48

cspell fixes

446e9f1

Update sdk/core/azure_core_opentelemetry/src/span.rs

fc57023

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update sdk/core/azure_core_opentelemetry/src/tracer.rs

7cbcf7b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

clippy and format fixes

3150ae2

Merge branch 'main' into larryo/opentelemetry_prototype_implementation

024d192

LarryOsterman mentioned this pull request Jul 22, 2025

It should be possible to let service clients set the schema URL in the future. #2810

Open

RickWinter approved these changes Jul 22, 2025

View reviewed changes

LarryOsterman enabled auto-merge (squash) July 22, 2025 20:45

Merge with pervious PR

0921536

RickWinter approved these changes Jul 22, 2025

View reviewed changes

LarryOsterman merged commit 737a9a1 into Azure:main Jul 22, 2025
17 checks passed

LarryOsterman deleted the larryo/opentelemetry_prototype_implementation branch July 22, 2025 22:46

Distributed Tracing integration with SDK builds. #2741

Distributed Tracing integration with SDK builds. #2741

Conversation

LarryOsterman commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lmolkova left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LarryOsterman commented Jul 16, 2025

Uh oh!

analogrelay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LarryOsterman commented Jun 30, 2025 •

edited

Loading